Closed
Conversation
Collaborator
|
FYI, to set the clear colour of a window you simply set via the window->clearColor() method i.e. windowColor->clearColor().set(r,g,b,a); |
Collaborator
|
I'm going to close this PR as Window::clearColor().set(r,g,b,a) is sufficient already and adding extra control into WindowTraits would leave it open to getting out of sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add clear color field to WindowTraits and use it as window clear color.
Description
I recently start using VulkanSceneGraph and did not find any way to change clear color of the window.
This PR add corresponding field to WindowTraits and force to use it as window background clear color.
Default value of clear color stays same as before.
Additionally i add .qtcreator folder (QtCreator setting folder starts from 19.0) to .gitignore file.